Login

Janesh · 09-24-2003, 09:02 AM

Help!!...Its like, every program i code, there end up being too many bugs!!

This program its long but please help me shows too many errors and im finding it hard to debug it.
Can you help me please.

This program is of A Music Store.
THe User has an option to Input weather he wants :
1: CD or Cassette
After This he can input if he wants
2: English or Hindi [I come from India, where Hindi is like, damn common]

3:Then All The Genres Show up and he has to choose which one.

4:Then all the albums show up and according to the number inputted it gets saved in a file "cart.dat" and keeps asking you if you want to buy any more music.
5: Once you say no, It prints the entire bill slong with the album youve purchased
6: It ends the program Smile

Heres the code [Doubt It will Fit] :

Code:
CLS

WHILE MM$ = "Y"

REM **Menu**

PRINT "Welcome To Janesh's Music Store"

PRINT "1:Buy A Record"

PRINT "2:Buy Music Accesories"

INPUT "Your Choice"; C

ON C GOSUB 1000, 3000

REM **Intro To Buying**

CLS

PRINT "At Janesh's Music Store, You Get A Step By Step Easy Menu To"

PRINT "Access And Buy Your Faviorate Music"

PRINT "All You Have To Do Is Feed In The Number And Let My Program"

PRINT "Do The Rest"

PRINT

PRINT "Please Press A Key To Continue"

SLEEP

WHILE YN$ = "Y"

CLS

REM **CD Or Cassette**

PRINT "Do You Wish To Purchase A"

PRINT "1: CD"

PRINT "2: Cassette"

INPUT CDCASSETTE

CLS

REM **Hindi Or English**

PRINT "Do You Want"

PRINT "1: An English Record"

PRINT "2: A Hindi Record"

INPUT HINENG

ON HINENG GOSUB 1400, 2500

OPEN "cart.dat" FOR OUTPUT AS #1

WRITE #1, RECORDNAME$, ARTIST$, COST

INPUT "Any More Purchases[Y/N]"; YN$

IF YN$ = "N" THEN

CLS

PRINT "Go Back To Main Menu ?"

INPUT MM$

IF MM$ = "N" Then END

WEND

WEND

CLOSE #1

REM **PRINTING THE BILL**

CLS

OPEN "cart.dat" FOR INPUT AS #1

WHILE NOT EOF(1)

INPUT #1, RECORDNAME$, ARTIST$, COST

LET FINALCOST = COST + FINALCOST

PRINT RECORDNAME$; "By :- "; ARTIST$; "For Rs."; COST

WEND

PRINT "Final Cost ="; FINALCOST

CLOSE #1

PRINT "Hope You Had A Good Time"

PRINT "Goodbye"

PRINT "Press A Key To Exit The Program"

SLEEP

KILL "cart.dat"

CLOSE #1

END

REM **English Genre**

CLS

PRINT "Please Choose The Genre Of Music You Like To Buy"

PRINT "1: Pop"

PRINT "2:Rock"

PRINT "3:Rap/RNB"

PRINT "4:Classics"

INPUT ENGGENRE

ON ENGGENRE GOSUB 1500, 1800, 2100, 2200

IF CDCASETTE = 1 THEN LET COST = 400 ELSE LET COST = 125

RETURN

REM **English Pop**

CLS

PRINT "Please Select The Album You Wish To Purchase"

PRINT "1:This is Me...Then     -JLo"

PRINT "2:Escape     -Enrique Iglesias"

PRINT "3:Beyonce     -Beyonce"

PRINT "4:Nsync     -Nsync"

PRINT "5:Oops I Did It Again     -Britney Spears"

INPUT ENGPOP

IF ENGPOP = 1 THEN LET RECORDNAME$ = "This is Me...Then": LET ARTIST$ = "JLo"

IF ENGPOP = 2 THEN LET RECORDNAME$ = "Escape": LET ARTIST$ = "Enrique Iglesias"

IF ENGPOP = 3 THEN LET RECORDNAME$ = "Beyonce": LET ARTIST$ = "Beyonce"

IF ENGPOP = 4 THEN LET RECORDNAME$ = "Nsync": LET ARTIST$ = "Nsync"

IF ENGPOP = 5 THEN LET RECORDNAME$ = "Oops I Did It Again": LET ARTIST$ = "Britney Spears"

RETURN

REM **English Rock**

CLS

PRINT "Please Select The Album You Wish To Purchase"

PRINT "1:St. Anger     -Mettalica"

PRINT "2:Meteora     -Linkin Park"

PRINT "3:Results May Vary     -Limp Bizkit"

PRINT "4:Steal This Album     -System Of A Down"

PRINT "5:Greatest Hits     -Guns 'N Roses"

INPUT ENGROCK

IF ENGROCK = 1 THEN LET RECORDNAME$ = "St. Anger": LET ARTIST$ = "Mettalica"

IF ENGROCK = 2 THEN LET ROCORDNAME$ = "Meteora": LET ARTIST$ = "Linkin Park"

IF ENGROCK = 3 THEN LET RECORDNAME$ = "Results May Vary": LET ARTIST$ = "Limp Bizkit"

IF ENGROCK = 4 THEN LET RECORDNAME$ = "Steal This Album": LET ARTIST$ = "System Of A Down"

IF ENGROCK = 5 THEN LET RECORDNAME$ = "Greatest Hits": LET ARTIST$ = "Guns 'N Roses"

RETURN

REM **English Rap**

CLS

PRINT "Please Select The Album You Wish To Purchase"

PRINT "1:The Eminem Show     -Eminem"

PRINT "2:50 Cent     -50 Cent"

PRINT "3:Pain Is Love     -Ja Rule"

PRINT "4:Straight Outta Compton     -NWA"

PRINT "5:Paid The Cost To Be The Boss     -Snoop Dogg"

INPUT ENGRAP

IF ENGRAP = 1 THEN LET RECORDNAME$ = "The Eminem Show": LET ARTIST$ = "Eminem"

IF ENGRAP = 2 THEN LET RECORDNAME$ = "50 Cent": LET ARTIST$ = "50 Cent"

IF ENGRAP = 3 THEN LET RECORDNAME$ = "Pain Is Love": LET ARTIST$ = "Ja Rule"

IF ENGRAP = 4 THEN LET RECORDNAME$ = "Striaght Outta Compton": LET ARTIST$ = "NWA"

IF ENGRAP = 5 THEN LET RECORDNAME$ = "Paid The Cost To Be The Boss": LET ARTIST$ = "Snoop Dogg"

RETURN

REM **English Classics**

CLS

PRINT "Please Select The Album You WishTo Purchase"

PRINT "1:#1     -The Beatles"

PRINT "2:Greatest Hits     -Elvis Prestly"

PRINT "3:5th Symphony     -Beethovan"

PRINT "4:Greatest Hits     -The BeeGees"

PRINT "5:ABBA     -Abba"

INPUT ENGCLA

IF ENGCLA = 1 THEN LET RECORDNAME$ = "#1": LET ARTIST$ = "The Beatles"

IF ENGCLA = 2 THEN LET RECORDNAME$ = "Greatest Hits": LET ARTIST$ = "Elvis Prestly"

IF ENGCLA = 3 THEN LET RECORDNAME$ = "5th Sumphony": LET ARTIST$ = "Beethovan"

IF ENGCLA = 4 THEN LET RECORDNAME$ = "Greatest Hits": LET ARTIST$ = "The BeeGees"

IF ENGCLA = 5 THEN LET RECORDNAME$ = "ABBA": LET ARTIST$ = "Abba"

RETURN

REM **Hindi Genre**

CLS

PRINT "Please Choose The Genre Of Music You Would Like To Buy"

PRINT "1: Indi Pop"

PRINT "2: Bollywood"

PRINT "3: Ghasals"

PRINT "4: Classics"

INPUT HINGENRE

ON HINGENRE GOSUB 2600, 2700, 2800, 2900

IF CDCASETTE = 1 THEN LET COST = 150 ELSE LET COST = 40

RETURN

REM **Indi Pop**

CLS

PRINT "Please Select The Album You Wish To Purchase"

PRINT "1: DJ Doll     -DJ Doll"

PRINT "2: Remixes     -RD Burman"

PRINT "3: Chadti Jawani Remix     -Various Artists"

PRINT "4: Remixes     -Asha Bhosle"

PRINT "5: Romanov IndiPop Tracks     -Various Artists"

INPUT HINPOP

IF HINPOP = 1 THEN LET RECORDNAME$ = "DJ Doll": LET ARTIST$ = "DJ Doll"

IF HINPOP = 2 THEN LET RECORDNAME$ = "Remixes": LET ARTIST$ = "RD Burman"

IF HINPOP = 3 THEN LET RECORDNAME$ = "Chadti Jawani Remix": LET ARTIST$ = "Various Artists"

IF HINPOP = 4 THEN LET RECORDNAME$ = "Remixes": LET ARTIST$ = "Asha Bhosle"

IF HINPOP = 5 THEN LET RECORDNAME$ = "Romanov IndiPop Tracks": LET ARTIST$ = "Various Artists"

RETURN

REM **Bollywood**

CLS

PRINT "Please Select The Album You Wish To Purchase"

PRINT "1:Boom     -The Sountrack"

PRINT "2:Chalte Chalte     -The Sountrack"

PRINT "3:Saathiya    -The Soundtrack"

PRINT "4:Hollywood Bollywood     -The Soundtrack"

PRINT "5:Mumbai Matinee     -The Soundtrack"

INPUT HINBOL

IF HINBOL = 1 THEN LET RECORDNAME$ = "Boom"

IF HINBOL = 2 THEN LET RECORDNAME$ = "Chalte Chalte"

IF HINBOL = 3 THEN LET RECORDNAME$ = "Saathiya"

IF HINBOL = 4 THEN LET RECORDNAME$ = "Hollywood Bollywood"

IF HINBOL = 5 THEN LET RECORDNAME$ = "Mumbai Matinee"

LET ARTIST$ = "The Soundtrack"

RETURN

REM **Ghassals**

CLS

PRINT "Please Select The Album You Wish To Purchase"

PRINT "1:Greatest Ghasals     -Jagjit Singh"

PRINT "2:Silsiley     -Jagjit Singh"

PRINT "3:Chants Of India     -Pundit Ravi Shankar"

PRINT "4:Songs Of The River     -Various Artists"

PRINT "5:Songs Of The Sea     -Various Artists"

INPUT HININS

IF HININS = 1 THEN LET RECORDNAME$ = "Greatest Ghasala": LET ARTIST$ = "Jagjit Singh"

IF HININS = 2 THEN LET RECORDNAME$ = "Silsiley": LET ARTIST$ = "Jagjit Singh"

IF HININS = 3 THEN LET RECORDNAME$ = "Chants Of India": LET ARTIST$ = "Pundit Ravi Shankar"

IF HININS = 4 THEN LET RECORDNAME$ = "Songs Of The River": LET ARTIST$ = "Various Artists"

IF HININS = 5 THEN LET RECORDNAME$ = "Songs Of The Sea": LET ARTIST$ = "Various Artists"

RETURN

REM **Classics**

PRINT "Please Select The Album You Wish To Purchase"

PRINT "1: Classics     -R D Burman"

PRINT "2: Memories     -Asha Bhosle"

PRINT "3: 60's Hits     -Various Artists"

PRINT "4: 70's Hits     -Various Artists"

PRINT "5: 80's Hits     -Various Artists"

INPUT HINCLA

IF HINCLA = 1 THEN LET RECORDNAME$ = "Classics": LET ARTIST$ = "R D Burman"

IF HINCLA = 2 THEN LET RECORDNAME$ = "Memories": LET ARTIST$ = "Asha Bhosle"

IF HINCLA = 3 THEN LET RECORDNAME$ = "60's Hits": LET ARTIST$ = "Various Artists"

IF HINCLA = 4 THEN LET RECORDNAME$ = "70's Hits": LET ARTIST$ = "Various Artists"

IF HINCLA = 5 THEN LET RECORDNAME$ = "80's Hits": LET ARTIST$ = "Various Artists"

RETURN

REM **Accesories**

WHILE YNN$ = "Y"

PRINT "Please Select An Item You Want To Buy"

PRINT "1:Walkman"

PRINT "2:Diskman"

PRINT "3:Speakers"

PRINT "4:CD Cleaner"

INPUT ACC

IF ACC = 1 THEN LET ACC$ = "Walkman": LET COST = 1000

IF ACC = 2 THEN LET ACC$ = "Diskman": LET COST = 2000

IF ACC = 3 THEN LET ACC$ = "Speakers": LET COST = 4000

IF ACC = 4 THEN LET ACC$ = "CD Cleaner": LET COST = 100

OPEN "acc.dat" FOR OUTPUT AS #1

WRITE #1, ACC$, COST

INPUT "Do You Want To Purchase Any More Accesories ?"; YNN$

WEND

REM **Bill For Accesories**

CLS

OPEN "acc.dat" FOR INPUT AS #1

WHILE NOT EOF(1)

LET FINALCOST = COST + FINALCOST

PRINT ACC$, "For Rs."; COST

WEND

PRINT "Final Cost = "; FINALCOST

PRINT "Please Press A Key To Go Back To Main Menu"

SLEEP

RETURN

Wow, it did fit! Lol..
Now please run it and see if it works. [Doubt it]
If it doesn't can you debug it for me please!!!

Agamemnus · 09-24-2003, 07:05 PM

Suggestions:

1) Use only labels that you need, and label them descriptively. (no number labels!)

2) Use lowercase for variable (string integer etc) names.

3) Instead of REM use '.

4) Use SELECT CASE or an array instead of the multiple IF statements...

5) Get rid of LET...

Also, you should check on your spelling in the code. IT SUCKS!

Janesh · 09-24-2003, 09:46 PM

[sarcasm]
thanks for the help
[/sarcasm]

Agamemnus · 09-24-2003, 09:54 PM

If you at least get rid of the line numbers (where is remline where you need it?), I'll help...

Janesh · 09-24-2003, 10:26 PM

ok fine i got rid of them, now get to the help already!

Mango · 09-24-2003, 10:59 PM

Quote:ok fine i got rid of them, now get to the help already!

You shouldn't take insult. Your code does, in fact look like Spaghetti code
http://www.wikipedia.org/wiki/Spaghetti_code
written in apple BASIC
http://www.applefritter.com/apple1/basic/
Try to learn about structured progamming
http://acweb.colum.edu/users/rcourington...uprog.html

I took considerable effort to try to give you guidance in the beginner's forum. You post this crap in the programming help forum. People here are happy to help, but when you post crap, are offered advice, then refuse to consider that, indeed your code is so crappy that it's not worth revising...it's a loss. Start over with a better plan. There are no less than 15 people here who could write your program for you in an hour's time. To get decent results, I speculate that it will take *you* substantially longer. If you want help, ask *and* listen to what people have to offer. If you want someone else to do your work for you, and you are not really interested in learning how to program, then hire a programmer to do the work for you.

I don't often post with a hostile tone, but...well...you deserve it.

Here's a hint. Don't hard code your data in print statements. It's foolish. Put your data (eg album info) in a file, then have your program read and and display the data contained in the file. That way, you can get the program working, then just update the file as needed...only modifying the program to add *features*, not more data.

Agamemnus · 09-24-2003, 11:04 PM

Code:
ok fine i got rid of them, now get to the help already!

Post the program without all the extra line numbers. (try to edit your first post)

I was actually going to rewrite the code, but with the line numbers, instead of 15 minutes it would have taken me considerably longer.

Janesh · 09-25-2003, 12:22 PM

nah, i got it

P.S :- Dont get so pissed off for such small things man!!take it easy!!

Login
Username:
Password:	Lost Password?
	Remember me